Timm Bäder [Sat, 24 Aug 2019 05:24:49 +0000 (07:24 +0200)]
cssstyle: Remove unused _add_difference
Timm Bäder [Fri, 23 Aug 2019 15:14:40 +0000 (17:14 +0200)]
stylecontext: Remove leftover function prototypes
Timm Bäder [Fri, 23 Aug 2019 15:09:54 +0000 (17:09 +0200)]
stylecontext: Stop exporting _resolve_color
Only used in gtkstylecontext.c
Timm Bäder [Fri, 23 Aug 2019 07:07:29 +0000 (09:07 +0200)]
csscolorvalue: return the initial color value directly
Timm Bäder [Fri, 23 Aug 2019 06:15:42 +0000 (08:15 +0200)]
csscolorvalue: Remove unused new_from_rgba()
Timm Bäder [Thu, 22 Aug 2019 17:25:22 +0000 (19:25 +0200)]
cssstaticstyle: Compute initial/inherit values directly
Timm Bäder [Thu, 22 Aug 2019 17:24:17 +0000 (19:24 +0200)]
cssinitialvalue: Make _compute public
So we can use it in cases where the class of css value is known to be an
initial one.
Timm Bäder [Thu, 22 Aug 2019 16:08:51 +0000 (18:08 +0200)]
csslookup: Remove 'relevant' parameter from _init
Unused.
Timm Bäder [Thu, 22 Aug 2019 16:00:37 +0000 (18:00 +0200)]
csslookup: Remove 'missing' bitmask
It's almost never useful to have a bitmask here, since it's only used
for the intersection case in gtk_css_style_provider_lookup. However,
even if that returns true, we still need to check every single style
property for being set again in the look afterwards.
Just remove the bitmask.
Timm Bäder [Thu, 22 Aug 2019 11:14:57 +0000 (13:14 +0200)]
cssanimatedstyle: Keep transition_info_add from recursing
The slowest part of that fuction is the type check for
GtkCssShorthandProperty. Subproperties of shorthand properties never
refer to more shorthand properties however, so we don't want to have the
type check for those.
Timm Bäder [Thu, 22 Aug 2019 10:54:36 +0000 (12:54 +0200)]
csslookup: Remove tautological if expression
A value is always either set or missing.
This was changed in
a1f7c459b75fe47e2abb7e856e6d4a4ad5208cb9, which
removed the ability for partial style computation.
Timm Bäder [Thu, 22 Aug 2019 10:14:33 +0000 (12:14 +0200)]
cssstaticstyle: Avoid ref'ing specified value in compute_value
There are alerady _get functions for GtkCssInheritValue and
GtkCssInitialValue, so use those. We can avoid a ref+unref pair this
way.
Timm Bäder [Wed, 21 Aug 2019 09:19:35 +0000 (11:19 +0200)]
cssprovider: Fix compilation wth VERIFY_TREE set
Timm Bäder [Wed, 21 Aug 2019 09:18:22 +0000 (11:18 +0200)]
cssmatcher: Inline node values into matcher
So we don't have to go through the matcher->node->decl every time
Timm Bäder [Mon, 19 Aug 2019 09:06:04 +0000 (11:06 +0200)]
cssanimatedstyle: Make set_animated_value transfer-full
Timm Bäder [Mon, 19 Aug 2019 08:56:19 +0000 (10:56 +0200)]
cssimage: Use gtk_internal_return_val_*
GtkCssImage is not public and being used in hot paths, e.g. CSS.
Timm Bäder [Mon, 19 Aug 2019 08:54:09 +0000 (10:54 +0200)]
gtkprivate: Only define gtk_internal_return_if* for consistency checks
The wanted behavior here is that these are only defined if the buildtype
is debug, i.e. full debugging.
Timm Bäder [Mon, 19 Aug 2019 07:42:51 +0000 (09:42 +0200)]
cssanimatedstyle: Save animation in array
Timm Bäder [Mon, 19 Aug 2019 06:46:27 +0000 (08:46 +0200)]
cssanimatedstyle: Avoid type check in loop
We can just do the check once as source is not going to change within
the loop.
Timm Bäder [Mon, 19 Aug 2019 06:45:07 +0000 (08:45 +0200)]
cssanimatedstyle: Avoid unnecessary transition work
No need to do all the transition work if the transition duration will be
0 for all of them.
Timm Bäder [Fri, 23 Aug 2019 06:14:54 +0000 (08:14 +0200)]
cssrgbavalue: Add & use new_white()
Timm Bäder [Fri, 23 Aug 2019 06:13:20 +0000 (08:13 +0200)]
cssrgbavalue: Add an opaque white singleton
Used a few hundred times in the widget-factory.
Timm Bäder [Sat, 17 Aug 2019 17:53:32 +0000 (19:53 +0200)]
cssrgbavalue: Add a singleton for transparent colors
The most common background color is no background color.
Timm Bäder [Sat, 17 Aug 2019 17:29:44 +0000 (19:29 +0200)]
cssdimensionvalue: Create a few more common singletons
Timm Bäder [Sat, 17 Aug 2019 17:08:16 +0000 (19:08 +0200)]
cssstaticstyle: Make set_value (transfer-full)
We only call this in one place and we can avoid a ref + unref pair this
way.
Timm Bäder [Sat, 17 Aug 2019 16:55:35 +0000 (18:55 +0200)]
css: Avoid more type checks in hot paths
Timm Bäder [Sat, 17 Aug 2019 16:23:36 +0000 (18:23 +0200)]
csspalettevalue: Use simple arrays instead of a hashtable
Use two sorted name/value arrays to save the colors instead of a
hashtable. This makes palette values faster to compare etc.
Timm Bäder [Sat, 17 Aug 2019 14:12:57 +0000 (16:12 +0200)]
cssanimatedstyle: Remove some casts in hot paths
gtk_css_animated_style_create_css_transitions down from 16% to 11%
when repeatedly clicking on a spinbutton button in the widget factory.
Timm Bäder [Thu, 22 Aug 2019 15:16:21 +0000 (17:16 +0200)]
bitmask: Add _gtk_allocated_bitmask_to_string
Timm Bäder [Fri, 23 Aug 2019 07:40:29 +0000 (09:40 +0200)]
Adwaita: Hack around list button styling
Once again.
Timm Bäder [Fri, 23 Aug 2019 07:40:02 +0000 (09:40 +0200)]
widget-factory: Add a spinbutton in a list
Timm Bäder [Fri, 23 Aug 2019 07:32:00 +0000 (09:32 +0200)]
spinbutton: Use a box layout
Timm Bäder [Thu, 22 Aug 2019 07:06:43 +0000 (09:06 +0200)]
menubutton: Add a create_popup_func
Some use cases require a menu button to create the popup on demand.
Timm Bäder [Thu, 22 Aug 2019 06:04:24 +0000 (08:04 +0200)]
menubutton: Remove unused member
Timm Bäder [Thu, 22 Aug 2019 10:41:39 +0000 (12:41 +0200)]
label: Remove "line" from wrap properties
The property names are "wrap" and "wrap-mode", so it doesn't make sense
that the accessors refer to line_wrap and line_wrap_mode.
Timm Bäder [Wed, 21 Aug 2019 08:56:20 +0000 (10:56 +0200)]
gsktransform: Fix documentation comment
There is no @m.
Timm Bäder [Fri, 16 Aug 2019 05:17:41 +0000 (07:17 +0200)]
snapshot: Stop exporting _append_node_internal
Unused outside of gtksnapshot.c
Timm Bäder [Sun, 8 Sep 2019 07:40:55 +0000 (07:40 +0000)]
Merge branch 'wip/chergert/remove-emit-by-name' into 'master'
texttag: avoid use of g_signal_emit_by_name()
See merge request GNOME/gtk!1088
Piotr Drąg [Sat, 7 Sep 2019 11:29:47 +0000 (13:29 +0200)]
Update POTFILES.skip
Marek Černocký [Sat, 7 Sep 2019 10:10:12 +0000 (12:10 +0200)]
Updated Czech translation
Emin Tufan Çetin [Fri, 6 Sep 2019 18:50:05 +0000 (18:50 +0000)]
Update Turkish translation
Christian Hergert [Thu, 5 Sep 2019 02:39:24 +0000 (19:39 -0700)]
texttag: avoid use of g_signal_emit_by_name()
This avoids looking up the signal by name and instead uses the saved
signal identifier from gtktexttagtable.c
Matthias Clasen [Wed, 4 Sep 2019 17:02:06 +0000 (17:02 +0000)]
Merge branch 'wip/chergert/faster-comparison' into 'master'
textlayout: remove use of GtkTextIter in line comparison
See merge request GNOME/gtk!1087
Christian Hergert [Wed, 4 Sep 2019 16:12:54 +0000 (09:12 -0700)]
textlayout: remove use of GtkTextIter in line comparison
We do not need to create a GtkTextIter to perform the comparison here as
that will require a number of validation steps that are extra work
compared to just discovering the GtkTextLine number directly.
Matthias Clasen [Tue, 3 Sep 2019 14:38:30 +0000 (14:38 +0000)]
Merge branch 'gtk-4-issue2128' into 'master'
[gtk4] wayland: Fix xdg-output v3 support
See merge request GNOME/gtk!1082
Olivier Fourdan [Tue, 3 Sep 2019 13:59:18 +0000 (15:59 +0200)]
wayland: Fix xdg-output v3 support
The xdg_output.done event is deprecated in xdg-output v3, so clients
need to rely on the wl_output.done event instead.
However, applying the changes on the fist wl_output.event when using
xdg-output v3 may lead to an incomplete change, as following xdg-output
updates may follow.
Make sure we apply xdg-output events on wl_output.done events with
xdg-output v3.
https://gitlab.gnome.org/GNOME/gtk/issues/2128
Jordi Mas [Sun, 1 Sep 2019 06:28:18 +0000 (08:28 +0200)]
Update Catalan translation
Ryuta Fujii [Sat, 31 Aug 2019 13:45:30 +0000 (13:45 +0000)]
Update Japanese translation
Ryuta Fujii [Sat, 31 Aug 2019 12:31:35 +0000 (12:31 +0000)]
Update Japanese translation
Ryuta Fujii [Sat, 31 Aug 2019 12:27:01 +0000 (12:27 +0000)]
Update Japanese translation
Changwoo Ryu [Fri, 30 Aug 2019 14:10:45 +0000 (14:10 +0000)]
Update Korean translation
Timm Bäder [Thu, 29 Aug 2019 13:56:13 +0000 (13:56 +0000)]
Merge branch 'typo' into 'master'
popover: fix typo in schema string
See merge request GNOME/gtk!1071
Alexandre Franke [Thu, 29 Aug 2019 12:53:34 +0000 (12:53 +0000)]
Update French translation
Alexandre Franke [Thu, 29 Aug 2019 12:50:20 +0000 (14:50 +0200)]
popover: fix typo in schema string
Ask Hjorth Larsen [Thu, 29 Aug 2019 10:37:41 +0000 (12:37 +0200)]
Updated Danish translation of gtk-properties
Ask Hjorth Larsen [Thu, 29 Aug 2019 10:37:41 +0000 (12:37 +0200)]
Updated Danish translation of gtk
Jordi Mas [Wed, 28 Aug 2019 17:37:59 +0000 (19:37 +0200)]
Update Catalan translation
Benjamin Otte [Mon, 26 Aug 2019 17:00:34 +0000 (17:00 +0000)]
Merge branch 'wip/ricotz/issue2107' into 'master'
gsk: Add missing 'transfer full' annotations of instance parameters
Closes #2107
See merge request GNOME/gtk!1065
Rico Tzschichholz [Mon, 26 Aug 2019 13:24:29 +0000 (15:24 +0200)]
gsk: Add missing 'transfer full' annotations of instance parameters
Fixes https://gitlab.gnome.org/GNOME/gtk/issues/2107
Matthias Clasen [Mon, 26 Aug 2019 13:50:43 +0000 (13:50 +0000)]
Merge branch 'office-runner-crash' into 'master'
Fix a crash in gtk-builder-tool
See merge request GNOME/gtk!1064
Matthias Clasen [Mon, 26 Aug 2019 13:34:15 +0000 (15:34 +0200)]
Fix a crash in gtk-builder-tool
Crash pointed out by Bastien Nocera.
Testcase included.
Changwoo Ryu [Mon, 26 Aug 2019 11:20:16 +0000 (11:20 +0000)]
Update Korean translation
Timm Bäder [Mon, 26 Aug 2019 09:18:47 +0000 (09:18 +0000)]
Merge branch 'doc-typos' into 'master'
Minor typos in the Documentation (a/an)
See merge request GNOME/gtk!1061
Дилян Палаузов [Sun, 25 Aug 2019 12:52:24 +0000 (12:52 +0000)]
Minor typos in the Documentation (a/an)
Matthias Clasen [Sun, 25 Aug 2019 11:58:02 +0000 (11:58 +0000)]
Merge branch 'gdkmonitor-x11-manufacturer' into 'master'
gdk: x11: Fill GdkMonitor manufacturer with PNP id from EDID
Closes #1765
See merge request GNOME/gtk!859
Balázs Úr [Sat, 24 Aug 2019 20:23:45 +0000 (20:23 +0000)]
Update Hungarian translation
Anders Jonsson [Thu, 22 Aug 2019 09:45:38 +0000 (09:45 +0000)]
Update Swedish translation
Emmanuele Bassi [Wed, 21 Aug 2019 19:18:17 +0000 (19:18 +0000)]
Merge branch 'build-remove-xiproto-xreply-check-gtk4' into 'master'
Remove NEED_XIPROTO_H_FOR_XREPLY check
See merge request GNOME/gtk!1059
Christoph Reiter [Wed, 21 Aug 2019 18:46:30 +0000 (20:46 +0200)]
Remove NEED_XIPROTO_H_FOR_XREPLY check
It was only defined in the old autotools build to support a >20 year old x11,
https://bugzilla.gnome.org/show_bug.cgi?id=148032
Daniel Mustieles [Tue, 20 Aug 2019 10:45:23 +0000 (12:45 +0200)]
Updated Spanish translation
Daniel Șerbănescu [Mon, 19 Aug 2019 11:50:59 +0000 (11:50 +0000)]
Update Romanian translation
Daniel Șerbănescu [Mon, 19 Aug 2019 11:09:45 +0000 (11:09 +0000)]
Update Romanian translation
Aurimas Černius [Sun, 18 Aug 2019 18:41:16 +0000 (21:41 +0300)]
Updated Lithuanian translation
Kukuh Syafaat [Fri, 16 Aug 2019 09:16:05 +0000 (09:16 +0000)]
Update Indonesian translation
Asier Sarasua Garmendia [Fri, 16 Aug 2019 08:01:11 +0000 (08:01 +0000)]
Update Basque translation
Asier Sarasua Garmendia [Fri, 16 Aug 2019 07:55:49 +0000 (07:55 +0000)]
Update Basque translation
Timm Bäder [Thu, 15 Aug 2019 15:21:47 +0000 (17:21 +0200)]
scale: Add a destroy notify to set_format_value_func
Closes #2098
Timm Bäder [Thu, 15 Aug 2019 15:12:30 +0000 (17:12 +0200)]
scaler: Avoid some signal connections
We're mainly using this for icons that will never change contents or
size, and we're using a GtkScaler per such icon when on a hidpi setup,
so just avoid the two signal connections per icon.
Timm Bäder [Wed, 14 Aug 2019 09:33:56 +0000 (11:33 +0200)]
spinbutton: Use gtk_button_new_from_icon_name
Timm Bäder [Tue, 13 Aug 2019 10:29:00 +0000 (12:29 +0200)]
widget: Don't duplicate events to translate coordinates
Timm Bäder [Tue, 13 Aug 2019 10:10:43 +0000 (12:10 +0200)]
widget: Remove captured event handler code
Timm Bäder [Tue, 13 Aug 2019 10:08:36 +0000 (12:08 +0200)]
scrolledwindow: Stop using _gtk_widget_set_captured_event_handler
We can use an event controller with phase = CAPTURE these days.
Daniel Șerbănescu [Wed, 14 Aug 2019 09:07:20 +0000 (09:07 +0000)]
Update Romanian translation
(cherry picked from commit
1e8d46352e3cf85e1f12edaf43e73134a6419f29)
Daniel Șerbănescu [Wed, 14 Aug 2019 06:30:03 +0000 (06:30 +0000)]
Update Romanian translation
(cherry picked from commit
10603f95985940a45d283104b123aa5be006a6ed)
Matthias Clasen [Tue, 13 Aug 2019 21:18:41 +0000 (21:18 +0000)]
Merge branch '948-patch-renaming-a-file-can-make-it-to-loose-selection_GTK4' into 'master'
filechooser: keep file selected after being renamed
Closes #948
See merge request GNOME/gtk!1053
Matthias Clasen [Tue, 13 Aug 2019 19:16:03 +0000 (15:16 -0400)]
text view: Fix a typo
Pointed out in https://gitlab.gnome.org/GNOME/gtk/issues/2094
Jordi Mas [Tue, 13 Aug 2019 06:40:18 +0000 (08:40 +0200)]
Update Catalan translation
Daniel Șerbănescu [Tue, 13 Aug 2019 04:37:04 +0000 (04:37 +0000)]
Update Romanian translation
(cherry picked from commit
f9acfa1bd846f1caa411ac06177108ca2ba1d6c3)
Nelson Benítez León [Mon, 12 Aug 2019 21:32:56 +0000 (17:32 -0400)]
filechooser: keep file selected after being renamed
Because otherwise when the file list is sorted "by name"
and the new name causes the file to be re-sorted to another
row, the selection stays in the old row which is now
occupied by a different file.
Fixed by keeping track of the renamed file and revealing
it in the "row-changed" signal handler, which gets emitted
after a file is renamed.
Fixes issue #948
Daniel Șerbănescu [Mon, 12 Aug 2019 08:35:22 +0000 (08:35 +0000)]
Update Romanian translation
Piotr Drąg [Sun, 11 Aug 2019 12:37:14 +0000 (14:37 +0200)]
Update Polish translation
Timm Bäder [Sun, 11 Aug 2019 08:41:34 +0000 (10:41 +0200)]
Adwaita: Style spinbutton up/down children explicitly
Once again to increase the specificty above that of the
"list row button.etc." selector. Makes hovering spinbutton buttons in
lists look normal again.
Timm Bäder [Sun, 11 Aug 2019 08:30:01 +0000 (10:30 +0200)]
Adwaita: Update .devel headerbar styling
Just pull in the changes from gtk-3-24
Timm Bäder [Sun, 11 Aug 2019 08:06:52 +0000 (10:06 +0200)]
range: Avoid a divison by 0
Based on a patch by Blake Latchford
Fixes #618
Daniel Boles [Mon, 7 Aug 2017 09:38:37 +0000 (10:38 +0100)]
AccelLabel: Add get_accel_closure() accessor
Fixes #875
Timm Bäder [Sun, 11 Aug 2019 06:34:43 +0000 (08:34 +0200)]
color chooser: Port checkered pattern drawing from cairo
Timm Bäder [Sat, 10 Aug 2019 18:08:59 +0000 (20:08 +0200)]
range: Use public delay-factory API
Timm Bäder [Sun, 11 Aug 2019 06:53:10 +0000 (08:53 +0200)]
cellrenderer: Add accessors for {get,set}_is_expande{r,d}
Timm Bäder [Sat, 10 Aug 2019 17:56:10 +0000 (19:56 +0200)]
testsuite: Add another repeat node test case
Timm Bäder [Sat, 10 Aug 2019 17:50:17 +0000 (19:50 +0200)]
Adwaita: Fix hovering modelbutton arrows
This CSS snippet was supposed to only recolor the popover arrow but
ended up also recoloring the > arrow on modelbuttons that show a
submenu. Make the selector more specific.